Skip to content

Merge v1.1.1 into firehose/1.x#13

Merged
maoueh merged 6 commits into
firehose/1.xfrom
merge-1.1.1
Jun 19, 2026
Merged

Merge v1.1.1 into firehose/1.x#13
maoueh merged 6 commits into
firehose/1.xfrom
merge-1.1.1

Conversation

@sduchesneau

Copy link
Copy Markdown

Merges upstream Base v1.1.1 (tag) into the firehose-instrumented firehose/1.x branch.

Upstream changes in v1.1.1 (3 commits over v1.1.0)

Firehose adaptation (this PR's extra commit)

PR base#3603 changed FlashblockSequenceValidator::validate to take a 5th arg prev_flashblock_id: FlashblockId and added a NonSequentialPredecessor result variant. The firehose flashblocks processor calls this validator, so it was updated to:

  • pass flashblock.metadata.prev_flashblock_id (the Metadata struct gained this #[serde(default)] field)
  • handle the new NonSequentialPredecessor variant (reset state, wait for next base — same as NonSequentialGap)
  • update test Metadata literals for the added field

Verification

  • cargo check --workspace --all-targets: clean
  • cargo test -p base-firehose-flashblocks -p base-common-chains: pass (sequence + dispatcher integration tests included)

Note: building test-utils requires forge build in crates/utilities/test-utils/contracts to generate the new ParentBlockhashGuard.sol artifact (gitignored out/).

github-actions Bot and others added 6 commits June 18, 2026 11:53
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* chore(common): set mainnet activation date

Co-authored-by: Codex <codex-noreply@coinbase.com>

* fix ci after beryl mainnet scheduling

Co-authored-by: Codex <codex-noreply@coinbase.com>

* fix basectl unscheduled hardfork test

Co-authored-by: Codex <codex-noreply@coinbase.com>

---------

Co-authored-by: Codex <codex-noreply@coinbase.com>
* insert parent block hash into pending EVM

* typed errors for FlashblockId, use pair of Atomics

* fix test failures due to harness adjustment

* fmt fix

* chore: retrigger CI for release retarget
v1.1.1 (PR base#3603) added a prev_flashblock_id predecessor-link arg to
FlashblockSequenceValidator::validate and a NonSequentialPredecessor
result variant. Pass metadata.prev_flashblock_id from the firehose
processor, handle the new variant (reset + wait for base), and update
test Metadata literals for the added field.
Tests for the v1.1.1 NonSequentialPredecessor path in the firehose
flashblocks processor: mismatched prev_flashblock_id resets state,
matching id is accepted, default (unset) id stays backward-compatible.
Adds flash_delta_with_prev_id test helper.

Docs under docs/firehose/ answer four review questions: the reset
tests, Dockerfile.sf build status, Beryl block-model impact, and the
pending-EVM parent-hash fix.
@maoueh maoueh merged commit 7170f32 into firehose/1.x Jun 19, 2026
2 checks passed
@maoueh maoueh deleted the merge-1.1.1 branch June 19, 2026 14:07
sduchesneau added a commit that referenced this pull request Jun 19, 2026
Committed unintentionally via PR #13; these were review notes, not
meant to land in the tree.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants